Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): force delete with shift key #6239

Merged
merged 15 commits into from
Jan 17, 2024
Merged

feat(web): force delete with shift key #6239

merged 15 commits into from
Jan 17, 2024

Conversation

martabal
Copy link
Member

@martabal martabal commented Jan 8, 2024

Changes made in this PR

With this PR, you can delete assets without trashing them with Shift + Delete

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Jan 8, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2df9e43
Status:⚡️  Build in progress...

View logs

@martabal martabal marked this pull request as ready for review January 14, 2024 00:51
@jrasm91
Copy link
Contributor

jrasm91 commented Jan 15, 2024 •
edited
Loading

On my ubuntu system, you have delete and shift delete. Shift delete only bypasses the trash, not the confirmation modal as well. I don't think it is a good idea to bypass the modal by default. If anything we should add an option to not show the confirm modal again after the first time.

@martabal
Copy link
Member Author

On my ubuntu system, you have delete and shift delete. Shift delete only bypasses the trash, not the confirmation modal as well. I don't think it is a good idea to bypass the modal by default. If anything we should add an option to not show the confirm modal again after the first time.

image

What do you think about that ?
Should we add a setting in the user settings to enable / disable this modal ?

@jrasm91 jrasm91 enabled auto-merge (squash) January 17, 2024 19:15
@jrasm91 jrasm91 merged commit c317fea into main Jan 17, 2024
20 of 21 checks passed
@jrasm91 jrasm91 deleted the feat/shortcut-force-delete branch January 17, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes

@alextran1502 alextran1502 alextran1502 left review comments

Assignees
No one assigned
Labels
🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martabal @jrasm91 @alextran1502