feat(mobile): long-press delete button to permanently delete asset #6240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
744fc50
|
| Status: | ⚡️ Build in progress... |
fyfrey
approved these changes
Jan 8, 2024
| } | ||
| } | ||
| : null, | ||
| onLongPressed: enabled | ||
| ? () => showDialog( |
There was a problem hiding this comment.
This block is identical to the case a few lines above. Consider moving this to a helper function if this makes things better to reduce code duplication.
|
We can merge this after #4505 |
shenlong-tanwen
changed the base branch from
main
to
feat/mobile-delete-local-only
shenlong-tanwen
force-pushed
the
feat/mobile-longpress-perma-delete
branch
from
df4e44c
to
8c1fcfa
Compare
shenlong-tanwen
force-pushed
the
feat/mobile-longpress-perma-delete
branch
from
d3f2df7
to
847c11e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made: