Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): check if sidecarPath exists #6293

Merged
merged 5 commits into from Feb 7, 2024
Merged

fix(server): check if sidecarPath exists #6293

merged 5 commits into from Feb 7, 2024

Conversation

JW-CH
Copy link
Contributor

@JW-CH JW-CH commented Jan 9, 2024

Fixes #6169

@JW-CH JW-CH changed the title check if sidecarPath exists fix(server): check if sidecarPath exists Jan 9, 2024
danieldietzler
danieldietzler requested changes Jan 9, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of all this? exiftool.read should just throw an error (which we catch in the repository readTags method)
Has been discussed on Discord

server/src/domain/metadata/metadata.service.ts Outdated Show resolved Hide resolved
jrasm91
jrasm91 previously approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this is something better suited for the sidecar sync/discover job. Sync can probably be updated to null out the database in the case the file no longer exists.

@jrasm91 jrasm91 dismissed their stale review January 9, 2024 18:43

mis-approved

@JW-CH
Copy link
Contributor Author

JW-CH commented Jan 10, 2024

TODO: Add valuable tests 🤣

@danieldietzler
Copy link
Member

Hey @JW-CH, just wanting to check in... Would you like us to add some tests or do you plan on adding them yourself?

@mmomjian mmomjian mentioned this pull request Jan 28, 2024
Closed
3 tasks
@danieldietzler danieldietzler marked this pull request as ready for review February 5, 2024 22:10
@jrasm91 jrasm91 enabled auto-merge (squash) February 7, 2024 17:30
@jrasm91 jrasm91 merged commit 4ea15a5 into immich-app:main Feb 7, 2024
23 checks passed
@mjulian87 mjulian87 mentioned this pull request Apr 25, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes

@danieldietzler danieldietzler danieldietzler approved these changes

Assignees
No one assigned
Labels
🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatically clean up removed sidecar files
3 participants
@JW-CH @danieldietzler @jrasm91