Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(server): domain and infra modules #6301

Merged
merged 1 commit into from
Jan 9, 2024
Merged

refactor(server): domain and infra modules #6301

merged 1 commit into from
Jan 9, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Jan 9, 2024 •
edited
Loading

In this PR:

  • Use overrideModule instead of IMMICH_TEST_ENV
  • Replace DynamicModule with DomainModule

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Jan 9, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: abd91ca
Status: ✅  Deploy successful!
Preview URL: https://84622aa1.immich.pages.dev
Branch Preview URL: https://refactor-e2e-1.immich.pages.dev

View logs

@alextran1502
Copy link
Contributor

What are the issues with the current setup that the refactoring helps to resolve?

@jrasm91
Copy link
Contributor Author

jrasm91 commented Jan 9, 2024

What are the issues with the current setup that the refactoring helps to resolve?

This change removes the need to use the IMMICH_TEST_ENV environment variable. It's also simpler to just use normal modules instead of dynamic modules. Right now we have e2e tests for API endpoints as well as microservice jobs and library scanning. It's a bit of a mess and my plan is to simplify how they are tested. Specifically, I'd like to look at testing microservices code separately from the api endpoints and having simpler relationships between the domain and infra modules will make that easier to accomplish.

@jrasm91 jrasm91 changed the title refactor: domain and infra modules refactor(server): domain and infra modules Jan 9, 2024
danieldietzler
danieldietzler approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preparations for some good stuff 👀

@jrasm91 jrasm91 merged commit 12dc7c4 into main Jan 9, 2024
22 checks passed
@jrasm91 jrasm91 deleted the refactor/e2e-1 branch January 9, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler danieldietzler approved these changes

Assignees
No one assigned
Labels
🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrasm91 @alextran1502 @danieldietzler