refactor(server): split api and jobs into separate e2e suites #6307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
5102273
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6d4e6885.immich.pages.dev |
| Branch Preview URL: | https://refactor-e2e-2.immich.pages.dev |
jrasm91
force-pushed
the
refactor/e2e-2
branch
3 times, most recently
from
75294c7
to
403a88f
Compare
jrasm91
commented
Jan 10, 2024
| @@ -33,8 +32,7 @@ describe(`${AssetController.name} (e2e)`, () => { | |||
| }); | |||
|
|
|||
| afterAll(async () => { | |||
| await db.disconnect(); | |||
| await app.close(); | |||
| await testApp.teardown(); | |||
There was a problem hiding this comment.
This is what was causing the process to hang (not cleaning up exiftool-vendored)
jrasm91
force-pushed
the
refactor/e2e-2
branch
from
403a88f
to
ea5491a
Compare
jrasm91
force-pushed
the
refactor/e2e-2
branch
from
ea5491a
to
5102273
Compare
mertalev
reviewed
Jan 10, 2024
alextran1502
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
fsync=off(refactor(server): e2e tests #4536)Next steps:
server/