Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: open api #6334

Merged
merged 1 commit into from
Jan 12, 2024
Merged

refactor: open api #6334

merged 1 commit into from
Jan 12, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Jan 11, 2024 •
edited
Loading

In this PR:

  • Move all open-api related scripts, templates, etc. into a new folder open-api/
  • Combine typescript-sdk client generation (for cli and web) into a single folder (open-api/typescript-sdk/)
  • Changed the typescript-sdk to an actual dependency, which cli and web now rely on directly.

Tested:

  • Production build

TODO:

  • Update docs
  • Update github workflow to push @immich/sdk on release

Open API folder:

image

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Jan 11, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a983517
Status: ✅  Deploy successful!
Preview URL: https://8331cd23.immich.pages.dev
Branch Preview URL: https://refactor-open-api.immich.pages.dev

View logs

@jrasm91 jrasm91 force-pushed the refactor/open-api branch 3 times, most recently from 7f901ae to a7982bd Compare January 11, 2024 19:05
@jrasm91 jrasm91 marked this pull request as ready for review January 11, 2024 21:04
danieldietzler
danieldietzler approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

alextran1502
alextran1502 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM feel free to merge, tested in a production build and all is good

@jrasm91 jrasm91 merged commit 2439c5a into main Jan 12, 2024
23 checks passed
@jrasm91 jrasm91 deleted the refactor/open-api branch January 12, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextran1502 alextran1502 alextran1502 approved these changes

@danieldietzler danieldietzler danieldietzler approved these changes

@zackpollard zackpollard Awaiting requested review from zackpollard

Assignees
No one assigned
Labels
🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrasm91 @alextran1502 @danieldietzler