Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): extract image description #6344

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

tlvince
Copy link
Contributor

@tlvince tlvince commented Jan 12, 2024

Extracts the image description (aka caption).

Per an image from with a description set in Lightroom:

$ exiftool swans.jpg | grep Swans
Image Description               : Swans & cygnets
Caption-Abstract                : Swans & cygnets
Description                     : Swans & cygnets

Closes #4220

@bo0tzz
Copy link
Member

bo0tzz commented Jan 12, 2024

How does this interact with a description set through the Immich UI?

@tlvince
Copy link
Contributor Author

tlvince commented Jan 12, 2024

I've not tested that scenario, only extraction on import. I'd assume it follows the same upsert behaviour of the other fields exposed on the UI (date, location)?

@bo0tzz
Copy link
Member

bo0tzz commented Jan 12, 2024

Since #5066, date and location are written to an XMP sidecar file when edited inside Immich. Maybe we should do the same for description here?

@jrasm91
Copy link
Contributor

jrasm91 commented Jan 12, 2024

We already write Image Description actually

@alextran1502
Copy link
Contributor

Hello! Can you help with fixing the e2e test?

@tlvince
Copy link
Contributor Author

tlvince commented Jan 15, 2024

👋🏻 @alextran1502, e2e's green now

@jrasm91 jrasm91 merged commit 984feaf into immich-app:main Jan 15, 2024
20 checks passed
@tlvince tlvince deleted the patch-1 branch January 15, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants