-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move asset stacks to their own entity #6353
Conversation
Deploying with Cloudflare Pages
|
25fb0ac
to
6ff6b9c
Compare
2f5a320
to
0937af9
Compare
e7a9de8
to
eace547
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, although I am having a hard time wrapping my head about the actual stacking/unstacking logic.
295f34b
to
643a9d5
Compare
cf8294b
to
6df4921
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like an entire asset-stack CRUD api exists inside of the bulk asset update endpoint now 😆, besides that I think this looks great. I was able to test creating stacks with the new code, as well as migrating from main to this branch and back again, all without losing existing stacks.
6df4921
to
19dc1d8
Compare
Refactor to move asset stacks to their own entity. This is the first part of this work. Bundled into this is also some initial work for auto-stacking burst assets.
To Do:
Further Work (Different PR(s)):