Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): uploadCounters increase only when files are uploaded #6357

Merged
merged 2 commits into from
Jan 18, 2024
Merged

fix(cli): uploadCounters increase only when files are uploaded #6357

merged 2 commits into from
Jan 18, 2024

Conversation

AngelPone
Copy link
Contributor

@AngelPone AngelPone commented Jan 13, 2024 •
edited

Description

Currectly the upload function increase the uploadCounter for every asset that can not skip, causing issue #6263.

This PR moves uploadCounter++; before, increase the counter only when files are actually uploaded.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable

@bo0tzz bo0tzz added the cli Tasks related to the Immich CLI label Jan 13, 2024
jrasm91
jrasm91 reviewed Jan 18, 2024
View reviewed changes
cli/src/commands/upload.ts Outdated Show resolved Hide resolved
@jrasm91 jrasm91 enabled auto-merge (squash) January 18, 2024 03:11
@jrasm91 jrasm91 merged commit b98d1bf into immich-app:main Jan 18, 2024
20 checks passed
@AngelPone AngelPone mentioned this pull request Jan 18, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes

@etnoy etnoy Awaiting requested review from etnoy

Assignees
No one assigned
Labels
cli Tasks related to the Immich CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AngelPone @jrasm91 @bo0tzz