New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): store accordion state in search params #6435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
danieldietzler
force-pushed
the
refactor/admin-settings-accordions-state
branch
2 times, most recently
from
January 24, 2024 20:54
4e5e0c4
to
31858cd
Compare
danieldietzler
force-pushed
the
refactor/admin-settings-accordions-state
branch
2 times, most recently
from
January 27, 2024 17:26
4dbc892
to
f9aa4e2
Compare
danieldietzler
changed the title
refactor(web): keep admin settings accordion state in search params
refactor(web): store accordion state in search params
Jan 27, 2024
danieldietzler
force-pushed
the
refactor/admin-settings-accordions-state
branch
from
January 27, 2024 18:02
f9aa4e2
to
4793fe7
Compare
martabal
reviewed
Jan 27, 2024
danieldietzler
force-pushed
the
refactor/admin-settings-accordions-state
branch
from
January 28, 2024 20:55
4793fe7
to
e366e93
Compare
danieldietzler
force-pushed
the
refactor/admin-settings-accordions-state
branch
from
February 7, 2024 23:13
e366e93
to
3d6f2f5
Compare
danieldietzler
force-pushed
the
refactor/admin-settings-accordions-state
branch
from
February 7, 2024 23:17
3d6f2f5
to
d484ccc
Compare
jrasm91
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If your happy with this new approach, everything works and looks good to me.
jrasm91
force-pushed
the
refactor/admin-settings-accordions-state
branch
from
February 9, 2024 20:18
a1aa4bb
to
52aac3a
Compare
jrasm91
changed the title
refactor(web): store accordion state in search params
feat(web): store accordion state in search params
Feb 9, 2024
martabal
approved these changes
Feb 10, 2024
web/src/lib/components/admin-page/settings/setting-accordion.svelte
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to store the state of accordions (
isOpen
?) in the URL. If an accordion component gets a keyfoo
, this key will be used in the URL. (i.e.demo.immich.app/admin/system-settings?isOpen=foo
)