Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 'Add' button on album user invite to the same row as 'To' List #6447

Merged

Conversation

A-wels
Copy link
Contributor

@A-wels A-wels commented Jan 17, 2024

This pull requests moves the "Add" Button in the album user adding modal to the same row as the list of added users in order to fix #6446.

Note: When adding many users, the users and the add button still get hidden behind a horizontal scrollbar.


Edit with Screenshots
Before:
Screenshot_20240117_122152

After:
Screenshot_20240117_122108

…n order to prevent the button getting hidden by a scrollbar
@jrasm91
Copy link
Contributor

jrasm91 commented Jan 17, 2024

You can add a screenshot to the PR description?

@A-wels
Copy link
Contributor Author

A-wels commented Jan 17, 2024

I added the images to the original post 👍

@jrasm91 jrasm91 enabled auto-merge (squash) January 17, 2024 14:32
@jrasm91 jrasm91 merged commit 702e911 into immich-app:main Jan 17, 2024
20 of 24 checks passed
@A-wels A-wels deleted the fix/badLayoutOnModalWhenAddingUsersToAlbum branch January 17, 2024 16:16
@waclaw66
Copy link
Contributor

That's how it looks like when multiple users is added...
obrazek

@martabal
Copy link
Member

looks fine to me on main with the latest commit (d5af357) on firefox and chrome 🤔

image

@waclaw66
Copy link
Contributor

looks fine to me on main with the latest commit (d5af357) on firefox and chrome 🤔

Please try to add more users to show vertical scrollbar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Web: bad layout on modal when adding users to album.
4 participants