feat(server, web): Added TranscodePolicy "Bitrate higher than max bitrate or not in accepted format" #6479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… was set by admin
…igher than set max bitrate
mertalev
force-pushed
the
bitrate_filter
branch
from
0ff5a30
to
7710074
Compare
|
@Hely0n I rebased the PR and it looks good. We can merge it once you add unit tests for the policy. |
Thank you very much. I plan to write them in the next days |
|
@mertalev I hope this unit test meets your expectations. I just oriented on the resolution policy. |
mertalev
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And here comes my last promise from #6319 :
The Bitratete policy.
This is just an additional transcode policy, which works like the "Transcode if higher than target resolution or not in desired format", but it will only transcode videos where the total bitrate is higher or equal than the bitrate set under "max bitrate".
This will allow admins to set the upload speed of the provider, where the server is running, as max bitrate so only videos that wouldn't be streamable due to their high bitrate will be transcoded regardless of their resolution.
This PR is build on top of my "Accepted Codecs"-PR ( #6460 ) .
With both features, the admin will have much more control about which videos have to be transcoded and thus allow for much better storage efficiency.