fix(web): prevent layout change from scrollbar in admin settings #6482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
2319196
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://59bce23a.immich.pages.dev |
| Branch Preview URL: | https://fix-web-scrollbar.immich.pages.dev |
alextran1502
approved these changes
Jan 19, 2024
mertalev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When initially visiting the admin settings, there may be no scrollbar. Currently, when an accordion is expanded and a scrollbar appears, all the settings are shifted slightly to the left. This PR adds the new scrollbar-gutter CSS property that allows the layout to compensate for this.
Notably, Safari only supports this property behind a feature flag, so it will not have an effect on this browser yet.
How Has This Been Tested?
The admin settings no longer shift when the scrollbar appears.