Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): slider #6485

Merged
merged 1 commit into from
Jan 19, 2024
Merged

fix(web): slider #6485

merged 1 commit into from
Jan 19, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Jan 19, 2024

No description provided.

Copy link

cloudflare-pages bot commented Jan 19, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4e1cd11
Status: ✅  Deploy successful!
Preview URL: https://ed1730d5.immich.pages.dev
Branch Preview URL: https://fix-web-slider.immich.pages.dev

View logs

@jrasm91 jrasm91 requested a review from martabal January 19, 2024 06:49
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would be nice if we could move the label with the title to the slider. So title would be a prop on the slider component

@alextran1502 alextran1502 merged commit dacca4c into main Jan 19, 2024
21 checks passed
@alextran1502 alextran1502 deleted the fix/web-slider branch January 19, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants