Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): album description #6512

Merged
merged 1 commit into from
Jan 19, 2024
Merged

fix(web): album description #6512

merged 1 commit into from
Jan 19, 2024

Conversation

martabal
Copy link
Member

Changes made in this PR

Screenshots

Before After
Screenshot from 2024-01-19 20-25-30 image
2024-01-19.20-30-23.mp4

@alextran1502 alextran1502 merged commit aa02ccb into main Jan 19, 2024
21 of 22 checks passed
@alextran1502 alextran1502 deleted the fix/album-description branch January 19, 2024 21:30
Comment on lines +152 to +157
const autoGrowHeight = () => {
// little hack so that the height of the text area is correctly initialized
textarea.scrollHeight;
textarea.style.height = '5px';
textarea.style.height = `${textarea.scrollHeight}px`;
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you just copied and pasted all of this stuff. Can you re-implement this without copy/pasting please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you want me to change ?
Just put it in a .ts file ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe look into a way to:

  • add a directive/attribute/use:autogrow thing that will just do it automatically
  • add a custom TextArea component that we can use everywhere we want a text box

also what is line 154?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without it, the textarea height is not correctly initialized:

2024-01-19.22-45-01.mp4

@ndragon798
Copy link

ndragon798 commented Jan 22, 2024

Hey @martabal it looks like this issue still happens on the album page if shared.

Running
image
image

Running latest 1.93.3

To recreate share the test album and open the share link.

@alextran1502
Copy link
Contributor

@ndragon798 this PR is merged but hasn't been released yet. It will be available in the next release

@ndragon798
Copy link

Ah alright I thought it was included.
image
https://github.com/immich-app/immich/releases/tag/v1.93.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] New lines aren't added to descriptions
4 participants