Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): delete user #6514

Merged
merged 1 commit into from
Jan 19, 2024
Merged

fix(web): delete user #6514

merged 1 commit into from
Jan 19, 2024

Conversation

martabal
Copy link
Member

fixes #6513

Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol what a stupid typo :D
Thanks!

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fa1d4ff
Status: ✅  Deploy successful!
Preview URL: https://f656ca88.immich.pages.dev
Branch Preview URL: https://fix-delete-user.immich.pages.dev

View logs

@martabal
Copy link
Member Author

It didn't take too long to figure out what the problem was 😆

I think this isn't the first time we've run into this kind of issue with the dispatcher, I don't know if svelte has any built in features to limit this.

@alextran1502 alextran1502 merged commit 68d4f1b into main Jan 19, 2024
22 checks passed
@alextran1502 alextran1502 deleted the fix/delete-user branch January 19, 2024 21:22
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not throwing an error? We're using typed dispatchers so this should be validated, no?

@martabal
Copy link
Member Author

Why is this not throwing an error? We're using typed dispatchers so this should be validated, no?

No, it does prevent that error

@jrasm91
Copy link
Contributor

jrasm91 commented Jan 19, 2024

Ah, maybe it would only prevent it if you used a custom event with a type that mismatched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting a user
4 participants