Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mobile): map heatmap color and location picker #6553

Merged
merged 8 commits into from Feb 8, 2024

Conversation

shenlong-tanwen
Copy link
Member

Changes made in the PR:

  • Updates the heat-map colors to use the previous gradient colors
  • Updates the location picker to display the buttons above the mobile navigation bar

Copy link

cloudflare-pages bot commented Jan 21, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b64abe0
Status:⚡️  Build in progress...

View logs

@shenlong-tanwen shenlong-tanwen marked this pull request as ready for review January 22, 2024 07:29
@alextran1502
Copy link
Contributor

The map keep crashing when I try to test this PR, can you run the PR again and see if you see the same thing?

@shenlong-tanwen
Copy link
Member Author

The map keep crashing when I try to test this PR, can you run the PR again and see if you see the same thing?

Thanks a lot. Looks like the android native library handles color strings in the format rgba(x,x,x) even if the alpha part is not available, however, the iOS native app on the other hand, crashes hard. Updated it and it should be good now

@alextran1502 alextran1502 enabled auto-merge (squash) February 8, 2024 03:06
@alextran1502 alextran1502 merged commit e086476 into main Feb 8, 2024
23 of 24 checks passed
@alextran1502 alextran1502 deleted the fix/mobile-heatmap-color branch February 8, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants