fix(web): statusbox re-rendering and nav bar when trashing assets #6581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
92c93bb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://48533073.immich.pages.dev |
| Branch Preview URL: | https://fix-web-small-issues-22-01.immich.pages.dev |
Comment on lines
51
to
54
| if (!$user) { | ||
| const { data } = await api.userApi.getMyUserInfo(); | ||
| $user = data; | ||
| } |
There was a problem hiding this comment.
Shouldn't this be handled by the store?
There was a problem hiding this comment.
Yep, that AIP request is useless, correct me if I'm wrong, but you're always authenticated when you have the side-bar and that store is already handled by auth.ts
|
This description stuff keeps popping up, can you keep it out of this PR, since it seems completely unrelated? |
jrasm91
approved these changes
Jan 22, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StatusBoxeach time a page loads.