Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(server): e2e #6632

Merged
merged 1 commit into from
Jan 24, 2024
Merged

refactor(server): e2e #6632

merged 1 commit into from
Jan 24, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Jan 24, 2024 •
edited
Loading

  • Consolidate e2e clients
  • Remove unused env variables for "run all tests"
  • Remove unused ifit usages
  • Update docs for split e2e tests
  • Removed unused job options for test app init, since all these tests are for jobs

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Jan 24, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9f60155
Status: ✅  Deploy successful!
Preview URL: https://5dafee9b.immich.pages.dev
Branch Preview URL: https://refactor-e2e-3.immich.pages.dev

View logs

danieldietzler
danieldietzler reviewed Jan 24, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Maybe it would be nice to have something like @api-test in server instead of always having to type the same relative path?

docs/docs/developer/testing.md Outdated Show resolved Hide resolved
@jrasm91 jrasm91 force-pushed the refactor/e2e-3 branch 2 times, most recently from be510a7 to ae30024 Compare January 24, 2024 21:07
danieldietzler
danieldietzler approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jrasm91 jrasm91 marked this pull request as ready for review January 24, 2024 22:24
@jrasm91 jrasm91 merged commit 852effa into main Jan 24, 2024
25 checks passed
@jrasm91 jrasm91 deleted the refactor/e2e-3 branch January 24, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler danieldietzler approved these changes

@etnoy etnoy Awaiting requested review from etnoy

Assignees
No one assigned
Labels
🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrasm91 @danieldietzler