feat(web): search filter form #6651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alextran1502
commented
Jan 26, 2024
•
alextran1502
commented
Deploying with
|
| Latest commit: |
5a4869a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://653f9f53.immich.pages.dev |
| Branch Preview URL: | https://feat-new-search-form.immich.pages.dev |
jrasm91
force-pushed
the
feat/new-search-form
branch
from
a6aedd0
to
98212c7
Compare
…nto feat/new-search-form
jrasm91
reviewed
Feb 2, 2024
| @@ -2,27 +2,37 @@ | |||
| // Necessary for eslint | |||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | |||
| type T = any; | |||
|
|
|||
| export type Type = 'button' | 'submit' | 'reset'; | |||
There was a problem hiding this comment.
there is probably a provided type for this already. HtmlButtonElement['type'] or something
jrasm91
reviewed
Feb 2, 2024
| <!-- SEARCH HISTORY BOX --> | ||
| {#if showHistory} | ||
| <SearchHistoryBox | ||
| on:clearAllSearchTerms={clearAllSearchTerms} |
There was a problem hiding this comment.
I would probably prefer an interface of:
clear: string?Omitting the term implies clear all. And then just have on:clear={({ detail: term }) => handleClear(term)}
There was a problem hiding this comment.
One is for clearing the individual search term, one is for clearing all of the terms.
Are you thinking that if we do not pass in the term, we will clear all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.