feat(web): Add places exploration page #6669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasm91
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Nice! Can you add a screenshot to the description that shows what the empty page looks like? Other things to consider, but can be dealt with later include:
- An option to make places show up in the sidebar automatically via User > Settings > Sidebar
- Refactor common elements between this and the faces page into reusable components
Add a place overview page, like the "People" page. This adds the same functionality as available on mobile.
l0nax
force-pushed
the
6092-web-missing-view-all-places-button
branch
from
355dde9
to
30579b8
Compare
|
@jrasm91 I've added the screenshot. Do we need to create an issue for the refactoring work? |
|
You can if you want, but it is not necessary. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the view all feature for places to the web interface. It's the same functionality as found on the mobile app.
Demonstration:
immich_dev_-_web-new-places-page.mp4
If the server returns no places:
Resolves #6092