Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ml): handle missing context_length field #6695

Merged
merged 2 commits into from
Jan 28, 2024

Conversation

mertalev
Copy link
Contributor

Description

A few models seem not to have context_length in their config.json file, so search will fail for these models. This PR sets a default of 77 in these cases.

How Has This Been Tested?

Tested by running Smart Search and searching with nllb-clip-large-siglip__v1 and XLM-Roberta-Large-ViT-H-14__frozen_laion5b_s13b_b90k.

Copy link

cloudflare-pages bot commented Jan 27, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e3e4130
Status: ✅  Deploy successful!
Preview URL: https://7bb1e866.immich.pages.dev
Branch Preview URL: https://fix-ml-handle-missing-contex.immich.pages.dev

View logs

machine-learning/app/config.py Show resolved Hide resolved
@mertalev mertalev merged commit 2249f7d into main Jan 28, 2024
24 checks passed
@mertalev mertalev deleted the fix/ml-handle-missing-context-length branch January 28, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants