Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename clip -> smart search #6713

Merged
merged 7 commits into from
Jan 29, 2024
Merged

Conversation

mertalev
Copy link
Contributor

@mertalev mertalev commented Jan 29, 2024

Description

There's an inconsistency where some places use Smart Search and others use CLIP. This changes everything in the server and web code to use Smart Search with the exception of the config file. It also renames mobile usages, but I'm less confident about this change.

How Has This Been Tested?

Tested that browsing and search works on web.

Copy link

cloudflare-pages bot commented Jan 29, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2ac7e16
Status: ✅  Deploy successful!
Preview URL: https://482f7a17.immich.pages.dev
Branch Preview URL: https://refac-rename-clip-smart-sear.immich.pages.dev

View logs

@mertalev mertalev changed the title refac: rename clip -> smart search refactor: rename clip -> smart search Jan 29, 2024
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mertalev mertalev merged commit ae7f174 into main Jan 29, 2024
26 checks passed
@mertalev mertalev deleted the refac/rename-clip-smart-search branch January 29, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants