Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): add warning when setting a quota superior to the disk size #6737

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

martabal
Copy link
Member

@martabal martabal commented Jan 29, 2024

fix for #6691

Screenshots

Screenshot from 2024-01-30 14-35-29

@etnoy
Copy link
Contributor

etnoy commented Jan 30, 2024

Just an idea, but can it display the warning already in the modal, when the number in the text field is too large?

I.e. like "quota is too large..." next to the text field, shown before you click the button? Hope this makes sense

@jrasm91
Copy link
Contributor

jrasm91 commented Jan 30, 2024

I like the idea of an inline form validation warning that the user can see prior to hitting save/update.

@martabal
Copy link
Member Author

Just an idea, but can it display the warning already in the modal, when the number in the text field is too large?

I.e. like "quota is too large..." next to the text field, shown before you click the button? Hope this makes sense

That's even better ! thanks

Copy link

cloudflare-pages bot commented Jan 30, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9e15318
Status:⚡️  Build in progress...

View logs

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alextran1502 alextran1502 enabled auto-merge (squash) January 30, 2024 17:19
@alextran1502 alextran1502 merged commit 7a1f25b into main Jan 30, 2024
23 of 24 checks passed
@alextran1502 alextran1502 deleted the feat/warning-quota-disk-size branch January 30, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants