Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): avoid leaking people data on shared links #6779

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

martabal
Copy link
Member

@martabal martabal commented Jan 30, 2024

Avoid leaking owner data on shared links when viewing as guest

Copy link

cloudflare-pages bot commented Jan 30, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c3e21d6
Status: ✅  Deploy successful!
Preview URL: https://6bf05d47.immich.pages.dev
Branch Preview URL: https://fix-leak-info-shared-link.immich.pages.dev

View logs

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Did you verify the test failed before your changes?

@martabal
Copy link
Member Author

martabal commented Jan 30, 2024

Perfect. Did you verify the test failed before your changes?

Yes, it failed 😄

image
image

@alextran1502 alextran1502 merged commit 1bfef20 into main Jan 30, 2024
24 checks passed
@alextran1502 alextran1502 deleted the fix/leak-info-shared-link branch January 30, 2024 21:34
@jrasm91
Copy link
Contributor

jrasm91 commented Jan 30, 2024

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants