Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mobile): Add end page to the end to memories #6780

Merged
merged 4 commits into from
Jan 30, 2024
Merged

feat(mobile): Add end page to the end to memories #6780

merged 4 commits into from
Jan 30, 2024

Conversation

martyfuhry
Copy link
Contributor

image

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Jan 30, 2024 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 38e4131
Status: ✅  Deploy successful!
Preview URL: https://c946d706.immich.pages.dev
Branch Preview URL: https://mobile-add-the-end-to-memori.immich.pages.dev

View logs

@martyfuhry martyfuhry marked this pull request as draft January 30, 2024 20:45
@martyfuhry
Copy link
Contributor Author

There's a bug here where scrolling down and back up quickly will have the wrong index for an image, but it's in production, as well.

@martyfuhry martyfuhry marked this pull request as ready for review January 30, 2024 20:56
@alextran1502 alextran1502 merged commit 149bc71 into main Jan 30, 2024
24 checks passed
@alextran1502 alextran1502 deleted the mobile/add-the-end-to-memories branch January 30, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextran1502 alextran1502 alextran1502 approved these changes

Assignees
No one assigned
Labels
📱mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martyfuhry @alextran1502