Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): dockerize #6858

Merged
merged 33 commits into from Feb 6, 2024
Merged

feat(cli): dockerize #6858

merged 33 commits into from Feb 6, 2024

Conversation

etnoy
Copy link
Contributor

@etnoy etnoy commented Feb 2, 2024 •
edited

  • Create docker image for v2 cli.
  • bump npm commander to v12
  • add documentation for docker usage of cli
  • fix module not found and allow the cli to run with esm

To be done after this PR:

  • push immich-cli image to ghcr

@etnoy etnoy added the cli Tasks related to the Immich CLI label Feb 2, 2024
@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Feb 2, 2024 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 99a0403
Status: ✅  Deploy successful!
Preview URL: https://7a8d7c89.immich.pages.dev
Branch Preview URL: https://cli-dockerize.immich.pages.dev

View logs

@etnoy etnoy mentioned this pull request Feb 5, 2024
Merged
@etnoy etnoy marked this pull request as ready for review February 5, 2024 18:47
@etnoy etnoy requested a review from jrasm91 February 5, 2024 19:29
jrasm91
jrasm91 reviewed Feb 5, 2024
View reviewed changes
cli/Dockerfile Outdated Show resolved Hide resolved
martabal
martabal approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@martabal martabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it will help a lot of people.
Thank you !

cli/Dockerfile Outdated Show resolved Hide resolved
docs/docs/features/command-line-interface.md Outdated Show resolved Hide resolved
@etnoy etnoy merged commit 31eb479 into main Feb 6, 2024
27 checks passed
@etnoy etnoy deleted the cli/dockerize branch February 6, 2024 11:17
lamarios
lamarios reviewed Feb 7, 2024
View reviewed changes
docs/docs/features/command-line-interface.md
If npm is not available on your system you can try the Docker version

```bash
docker run -it -v "$(pwd)":/import:ro -e IMMICH_API_KEY=https://your-immich-instance/api -e IMMICH_API_KEY=your-api-key ghcr.io/immich-app/immich-cli:latest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment variable for the server should be IMMICH_INSTANCE_URL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has already been fixed in a separate pr

@lamarios lamarios mentioned this pull request Feb 7, 2024
Closed
This was referenced Feb 28, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann left review comments

@lamarios lamarios lamarios left review comments

@jrasm91 jrasm91 jrasm91 left review comments

@bo0tzz bo0tzz bo0tzz left review comments

@martabal martabal martabal approved these changes

Assignees
No one assigned
Labels
cli Tasks related to the Immich CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@etnoy @benmccann @lamarios @jrasm91 @bo0tzz @martabal