fix(mobile): don't crop memories in landscape mode #6907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This conflicts with https://github.com/immich-app/immich/tree/feat/memories-animations . This PR is still relevant, as said branch does not fix the cropping issue. |
hrdl-github
force-pushed
the
fix-memory-crop
branch
from
e6dc1fb
to
425a925
Compare
martyfuhry
requested changes
Feb 17, 2024
hrdl-github
commented
Feb 17, 2024
hrdl-github
force-pushed
the
fix-memory-crop
branch
from
425a925
to
5c17ca7
Compare
|
LGTM! I'm not at my desk so I didn't test it, but this looks great! |
martyfuhry
approved these changes
Feb 17, 2024
|
@hrdl-github Can you re-base your changes over the latest main branch? |
hrdl-github
force-pushed
the
fix-memory-crop
branch
from
5c17ca7
to
9c2aebe
Compare
|
Rebased |
danieldietzler
pushed a commit
that referenced
this pull request
Feb 23, 2024
Don't crop memories in landscape mode unless aspect ratios are close Co-authored-by: hrdl <7808331-hrdl@users.noreply.gitlab.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6890