Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): auth file should be chmod 600 #6925

Merged
merged 5 commits into from Feb 5, 2024
Merged

fix(cli): auth file should be chmod 600 #6925

merged 5 commits into from Feb 5, 2024

Conversation

etnoy
Copy link
Contributor

@etnoy etnoy commented Feb 5, 2024 •
edited

Fixes #6911

  • Creates auth.yml with chmod 600
  • E2e tests for the correct chmod

@etnoy etnoy added security cli Tasks related to the Immich CLI labels Feb 5, 2024
@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Feb 5, 2024 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8ea64c5
Status: ✅  Deploy successful!
Preview URL: https://78ee2304.immich.pages.dev
Branch Preview URL: https://fix-cli-auth-access.immich.pages.dev

View logs

danieldietzler
danieldietzler approved these changes Feb 5, 2024
View reviewed changes
cli/test/e2e/login-key.e2e-spec.ts Outdated Show resolved Hide resolved
@etnoy etnoy merged commit ce6dc3b into main Feb 5, 2024
24 checks passed
@etnoy etnoy deleted the fix/cli-auth-access branch February 5, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann left review comments

@danieldietzler danieldietzler danieldietzler approved these changes

Assignees
No one assigned
Labels
cli Tasks related to the Immich CLI security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The auth.yml file generated by Immich CLI is world readable
3 participants
@etnoy @benmccann @danieldietzler