refactor(mobile): Use hooks to manage Chewie controller for video #7008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
a4128d3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://761938a6.immich.pages.dev |
| Branch Preview URL: | https://fix-video-delayed-loading-th.immich.pages.dev |
|
When you click on a video, I see that it is immediately in the immersive mode. Tapping on the screen, the control interface shows briefly and returns to the immersive mode. I think this is a bit inconvenient if you want to share a video, because you will have to aim to the middle of the screen to tap and then hit the pause button to get the control interface to show up |
|
That is definitely a bug. The intended behavior is for the controls to show for the |
…layed-loading-throbber
…hile playing and reverts hide controls timer to 5 seconds
martyfuhry
force-pushed
the
fix/video-delayed-loading-throbber
branch
from
f6ab532
to
985fcba
Compare
|
Rebased and working well on my end here! Ready for another round of review. |
…layed-loading-throbber
alextran1502
approved these changes
Feb 23, 2024
danieldietzler
pushed a commit
that referenced
this pull request
Feb 23, 2024
) * video loading delayed * Chewie controller implemented in hook * fixing look and feel * Finalizing delay and animations * Fixes issue with immersive mode showing immediately in videos * format fix * Fixes bug where video controls would hide immediately after showing while playing and reverts hide controls timer to 5 seconds * Fixed rebase issues --------- Co-authored-by: Alex Tran <alex.tran1502@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was all to improve the asset video playback experience while navigating the main timeline.