feat(server): restore modified at timestamp after upload, preserve when copying #7010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasm91
reviewed
Feb 10, 2024
Comment on lines
84
to
86
| await this.fixModifiedAtTimestamp(file, dto); | ||
| if (livePhotoFile) { | ||
| await this.fixModifiedAtTimestamp(livePhotoFile, dto); |
There was a problem hiding this comment.
These two can just go inside of the create method instead. Probably can move the sidecar one in there as well.
There was a problem hiding this comment.
Sounds good, I've moved all timestamp updating into the create method
| @@ -369,4 +375,8 @@ export class AssetService { | |||
| throw new BadRequestException('Quota has been exceeded!'); | |||
| } | |||
| } | |||
|
|
|||
| private async fixModifiedAtTimestamp(file: UploadFile, dto: CreateAssetDto) { | |||
| await utimes(file.originalPath, new Date(), new Date(dto.fileModifiedAt)); | |||
There was a problem hiding this comment.
We don't call fs methods directly in services. Can you just add this to the storage repository and use that here instead? It makes the tests simpler.
There was a problem hiding this comment.
Sounds good, I've added a utimes method to the storage repository/filesystem provider
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jextrevor
force-pushed
the
fix-modified-at-timestamps
branch
from
a5dca64
to
721bcb8
Compare
jextrevor
force-pushed
the
fix-modified-at-timestamps
branch
from
721bcb8
to
af785c2
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created to address #2581.
This change makes it so that the asset service restores the mtime of the asset file using the fileModifiedAt parameter.
Also, if renaming the file fails and the storage template service falls back to the copy and delete path instead, the filesystem provider now preserves the atime and mtime from the old file when copying.
This is my first time contributing - let me know if I missed something or what I can do to make this cleaner. Thanks!
(Also, not sure if I should be classifying this as a feature or a fix, I can change the commit message if needed)