refactor(web) open api client #7103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
0242a7e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://875a4182.immich.pages.dev |
| Branch Preview URL: | https://refactor-open-api-client.immich.pages.dev |
benmccann
approved these changes
Feb 14, 2024
| return names[jobName]; | ||
| }; | ||
|
|
||
| let _key: string | undefined; |
There was a problem hiding this comment.
This is fine for now, but having a single global key wouldn't work in the case that we had a cloud version of immich serving multiple users and doing ssr. It's not a change from the current code and not a blocker, but I thought I'd mention it anyway. Could potentially be worth a TODO. The typical way to avoid such a situation is with context: sveltejs/kit#4339 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #7097.
The only usages left are: