Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web) display wrong apikey-name on edit #7131

Merged
merged 4 commits into from Feb 16, 2024
Merged

fix(web) display wrong apikey-name on edit #7131

merged 4 commits into from Feb 16, 2024

Conversation

JW-CH
Copy link
Contributor

@JW-CH JW-CH commented Feb 15, 2024

Closes #7044

martabal
martabal reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@martabal martabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to change the APIKeyForm instead with let apiKeyName = apiKey.name; instead of export let apiKeyName = 'API Key';

@JW-CH
Copy link
Contributor Author

JW-CH commented Feb 15, 2024

Agreed. I'll change that.

@jrasm91 jrasm91 merged commit 67b1675 into immich-app:main Feb 16, 2024
24 checks passed
@shadowempire123
Copy link

not working for me...

@JW-CH JW-CH deleted the fix_apikey_edit branch February 26, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes

@danieldietzler danieldietzler danieldietzler approved these changes

@martabal martabal martabal approved these changes

Assignees
No one assigned
Labels
🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editing API key always shows "API Key" instead of current name
5 participants
@JW-CH @shadowempire123 @jrasm91 @danieldietzler @martabal