Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): empty/restore trash #7161

Merged
merged 3 commits into from Feb 17, 2024
Merged

Conversation

michelheusschen
Copy link
Contributor

@michelheusschen michelheusschen commented Feb 17, 2024

Emptying or restoring all assets from trash is currently not working, because in AssetRepository.getByUserId the userId is incorrectly used as assetId

Copy link

cloudflare-pages bot commented Feb 17, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b3206fb
Status: ✅  Deploy successful!
Preview URL: https://55f2667a.immich.pages.dev
Branch Preview URL: https://fix-server-empty-restore-tra.immich.pages.dev

View logs

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to add a test for this...? Maybe an e2e?

@michelheusschen
Copy link
Contributor Author

Is there any way to add a test for this...? Maybe an e2e?

e2e tests added

@alextran1502 alextran1502 merged commit 0730b54 into main Feb 17, 2024
25 checks passed
@alextran1502 alextran1502 deleted the fix/server-empty-restore-trash branch February 17, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants