feat(cli): concurrent upload #7192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
4086972
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://84923dd4.immich.pages.dev |
| Branch Preview URL: | https://feat-cli-concurrent-upload.immich.pages.dev |
mertalev
commented
Feb 19, 2024
|
I wonder if this fixes the problem with large files as well? |
jrasm91
reviewed
Feb 19, 2024
I don't think this will affect that. This PR just makes more uploads happen at once - the way it uploads videos won't change. |
mertalev
force-pushed
the
feat/cli-concurrent-upload
branch
from
338bbec
to
62aca17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When doing bulk uploads, I noticed that uploading through web was much faster than through the CLI (specifically when the upload component is minimized to avoid rendering slowdown). The former is able to upload files concurrently, while the latter currently does everything sequentially.
This PR addresses this limitation by refactoring the upload command to be "batch"-oriented - it runs a given number of promises at a time, finishing one step for all files before moving to the next step. Besides faster uploads, a benefit of this change is that it visualizes the progress of each step. In particular, this means users can now see how many of their assets were duplicates.