-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): small issues everywhere #7207
Conversation
Have you tested running |
Yes, It works fine |
Can we use this opportunity to fix the placeholder text color of "Add a title" in dark mode to be a little brighter? I've also found that having a lot of notifications for each action is making the screen busy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Deploying with
|
Latest commit: |
52a2b07
|
Status: | ✅ Deploy successful! |
Preview URL: | https://ac62e41b.immich.pages.dev |
Branch Preview URL: | https://fix-multiple.immich.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jrasm91 This change doesn't affect the user, as I understand, right? |
That is incorrect. Existing installations will have docker compose files with the start command referencing the bash script |
@jrasm91 The change here is for the |
Yes, I don’t think it’s a breaking change |
It is a breaking change since many users still use the old syntax and runs the .sh file directly from their docker compose. Those users need to update their compose file. Nevertheless, I think we should merge this before 1.95 and include a breaking change notice |
It doesn't matter. The breaking change is the fact that the start-microservices.sh file is being deleted. |
@@ -570,6 +555,8 @@ | |||
}; | |||
</script> | |||
|
|||
<svelte:window on:keydown={handleKeypress} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
422cf94
to
6f88769
Compare
This PR:
start-microservices.sh
andstart-server.sh
usage in favor ofstart.sh
(but still keep them)Screenshots