feat(server,web): remove external path nonsense and make libraries admin-only #7237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etnoy
added
tech-debt
Deploying with
|
| Latest commit: |
254b0c1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://83a572ca.immich.pages.dev |
| Branch Preview URL: | https://chore-admin-only-library.immich.pages.dev |
mertalev
changed the title
…e/admin-only-library
…e/admin-only-library
jrasm91
reviewed
Feb 21, 2024
…e/admin-only-library
…e/admin-only-library
etnoy
changed the title
jrasm91
approved these changes
Feb 28, 2024
|
Can we split the documentation to a separate PR that will be merged after the next release? |
|
That, or we do another release and merge this right before. |
|
I'll split the pr, that'll be the easiest |
…e/admin-only-library
|
Ready to merge, after the next release we merge #7526 |
|
There are still some docs changes in this PR |
Fixed, had forgot to push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make the library configuration admin-only. This removes a lot of complexity regarding external paths.
There is a new admin panel for external libraries. The configuration pane might be a better place for it, but it won't fit in a config file so I'm unsure.
User library settings have been removed.
We have a picker for library owner:
