Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): not in album filter with context search #7275

Merged
merged 1 commit into from Feb 21, 2024
Merged

Conversation

alextran1502
Copy link
Contributor

fix #7268

Copy link

cloudflare-pages bot commented Feb 20, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 59a23d4
Status: ✅  Deploy successful!
Preview URL: https://85be765e.immich.pages.dev
Branch Preview URL: https://fix-7268.immich.pages.dev

View logs

Copy link
Contributor

@mertalev mertalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah wait, I don't think this will work

@mertalev
Copy link
Contributor

We can't join on albums with smart search since it isn't a one-to-one or many-to-one relation

@alextran1502
Copy link
Contributor Author

I tested this and it works 😅

@mertalev
Copy link
Contributor

It will work, but the query won't produce the right results. See this comment

@alextran1502
Copy link
Contributor Author

@mertalev that's strange! The result visually show that it works 🤔

@mertalev
Copy link
Contributor

After looking at this again, I think this will work since this is effectively an anti-join that excludes assets in albums. It shouldn't have the duplicate row issue in this case.

@alextran1502 alextran1502 merged commit bb5236a into main Feb 21, 2024
24 of 26 checks passed
@alextran1502 alextran1502 deleted the fix-7268 branch February 21, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG(Server): Search with parameter "Not in any album" returns images that appear in an album
2 participants