chore(server): change transcode default to accept all supported audio codecs #7283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
40bbf16
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1a3b4e53.immich.pages.dev |
| Branch Preview URL: | https://chore-server-make-optimal-po.immich.pages.dev |
jrasm91
approved these changes
Feb 21, 2024
3 tasks
alextran1502
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change in #7106 can increase space usage quite a bit if the audio stream needs to be transcoded while the video stream does not. Accepting all supported audio codecs prevents this situation by default while still giving users the same flexibility. The accepted codec section in the admin settings has also been changed to add to existing options instead of overriding them.
Fixes #7280