Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): search with same face multiple times #7306

Merged
merged 1 commit into from Feb 21, 2024

Conversation

michelheusschen
Copy link
Contributor

Whan an asset contains a face multiple times, the search has wrong behavior. Let's say the asset contains the face of person A two times:

  • Search for person A --> no results
  • Search for person A + B --> 1 result, even though it doesn't have person B

Fixed by counting distinct persons instead of counting faces

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0c1112c
Status: ✅  Deploy successful!
Preview URL: https://6e36dec3.immich.pages.dev
Branch Preview URL: https://fix-server-search-face-multi.immich.pages.dev

View logs

@alextran1502 alextran1502 merged commit 173b470 into main Feb 21, 2024
25 of 26 checks passed
@alextran1502 alextran1502 deleted the fix/server-search-face-multiple-times branch February 21, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants