Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mobile): Removes analysis options for openapi directory #7309

Merged
merged 2 commits into from Mar 13, 2024

Conversation

martyfuhry
Copy link
Contributor

The openapi/analysis_options.yml file was causing the analyzer to include the entire openapi/ directory in the analyzer, which is contrary to our own analysis options.

@martyfuhry martyfuhry self-assigned this Feb 21, 2024
Copy link

cloudflare-pages bot commented Feb 21, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ed17715
Status: ✅  Deploy successful!
Preview URL: https://3980e8c9.immich.pages.dev
Branch Preview URL: https://chore-remove-analysis-option.immich.pages.dev

View logs

@alextran1502
Copy link
Contributor

that file is generated by openapi generator AFAIK, thus the failed check

@jrasm91
Copy link
Contributor

jrasm91 commented Feb 21, 2024

It looks like the file you deleted is auto generated. You may need to find another way to handle it. One option is to delete it after the client is generated. We have a bash script that handles generating the client and you could add an additional post-build step if there isn't a way to actually exclude it.

@martyfuhry martyfuhry merged commit 08d64f1 into main Mar 13, 2024
25 checks passed
@martyfuhry martyfuhry deleted the chore/remove-analysis-options-openapi branch March 13, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants