New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): rework combobox and add clear button #7317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
aria-expanded={isOpen} | ||
aria-controls={id} | ||
class="immich-form-input text-sm text-left w-full !pr-12 transition-[border-radius]" | ||
class:!pl-8={isOpen} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this syntax mean? I don't think I have seen it before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefixing a class with !
is Tailwinds way to add the !important
modifier. In this case to overwrite the padding set by .immich-form-input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, nice. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Not being able to deselect something was bugging me as well already :D
Deploying with Cloudflare Pages
|
No results
when there are no available optionsBefore
After