feat(web): search albums #7322
feat(web): search albums #7322
Conversation
Deploying with
|
| Latest commit: |
fb7a1e1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cf6d6118.immich.pages.dev |
| Branch Preview URL: | https://feat-search-albums.immich.pages.dev |
|
Apologies for commenting on a closed PR, but... would it be possible to do this on shared albums? (or maybe this applies there already)? |
|
This change only impacts the albums page, but in general it would be a good idea to consolidate the albums/shared albums pages to work the same. |
|
It's on my To do list |
|
I really appreciate this functionality, however there is a space for speed optimization. The page freezes for 3-4 second while searching among ~300 albums. |
|
The strange thing is that the first letter search is quite fast (<1s) after fresh page reload. When search input is cleared and first letter inserted again, it takes >3s. Even clearing the input is that slow. The search time depends on the letter, "e" is significantly slowed than "x", obviously because of frequency of occurrence. 2024-02-28.07.21.31.mp4The above described occurs on Win10 in Firefox (clear profile without addons), although it works normally fast (every search) in Chrome. |
|
Yes it's still an issue for large collections |
|
One easy fix would be to disable the animation when you have more than 100 albums |
|
Another glitch I've observed with this PR is that resolution of album thumbnails is lowered when search is performed. |
That's only workaround. I just wonder why it's fast for the first search only. The flip animation will probably change the html code so that the next animation will be much more complex. The same occurs with album sorting as well. |
|
The best solution would be to have an infinite-scroll mechanism instead of loading all albums. But that would be a big and complex refactor |
Search through albums
Screenshots
2024-02-21.21-56-54.mp4