Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): exclude archived assets from orphaned files #7334

Merged
merged 2 commits into from Feb 22, 2024

Conversation

michelheusschen
Copy link
Contributor

Fixes #7333

Copy link

cloudflare-pages bot commented Feb 22, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ff2a21e
Status: ✅  Deploy successful!
Preview URL: https://39291ff1.immich.pages.dev
Branch Preview URL: https://fix-server-archived-in-orpha.immich.pages.dev

View logs

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an e2e test for this?

@michelheusschen
Copy link
Contributor Author

Can you add an e2e test for this?

Added, however I had to add some functionality to clear the upload folder otherwise assets from other tests show up in the file report. Would love to know if there's a better way to clear uploads.

@jrasm91
Copy link
Contributor

jrasm91 commented Feb 22, 2024

Nah, I think that's perfect. We upload assets in other tests and don't delete them, so this seems fine IMO.

@jrasm91 jrasm91 merged commit 07ef008 into main Feb 22, 2024
25 checks passed
@jrasm91 jrasm91 deleted the fix/server-archived-in-orphaned-files branch February 22, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archived pictures appear as "untracked files" in v1.95.1
2 participants