New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web: Revamp message for Storage Template Engine in admin pannel #7359
Web: Revamp message for Storage Template Engine in admin pannel #7359
Conversation
<form autocomplete="off" on:submit|preventDefault class="mx-4 flex flex-col gap-4 py-4"> | ||
<div in:fade={{ duration: 500 }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This form isn't needed, the classes can be moved to the div
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michelheusschen Hmm fair, do you want me re-commit or toss it in with next PR. Also, on another note
Any idea to why there's a stutter to opening the storage-template menu in comparison to the other ones on admin template? Seems to do with transitions but I'm not too sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stutter is caused by loading the storage template options from the server, it will wait for a response and then render the settings.
immich/web/src/lib/components/admin-page/settings/storage-template/storage-template-settings.svelte
Line 88 in 3cd3411
{#await getTemplateOptions() then} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And for the original comment, you can just push a new commit no need to create a new PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks makes sense. About the PR I meant toss it in with another issue that I'll pick up. Anyways, I'll just commit it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michelheusschen committed, have a look
…ved unnessary code
* Web: Revamp message for Storage Template Engine in admin pannel * Web: Revamp message for Storage Template Engine in admin pannel: removed unnessary code
Had to close last PR due to ssh verification issue. #7349
As discussed in ##7339 and subsequently on discord, this commit adds necessary context to the storage-template on admin panel, like so