Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): improve search filter design #7367

Merged
merged 3 commits into from Feb 24, 2024

Conversation

michelheusschen
Copy link
Contributor

@michelheusschen michelheusschen commented Feb 23, 2024

  • Hide people section if there are none
  • Hide See all people button when all people are already shown
  • Moved people toggle button to save space and prevent it from jumping around
  • Removed horizontal lines and Filters text for a cleaner look
  • Improved responsive design

Before
search-filters-before

After
search-filters-after3

Copy link

cloudflare-pages bot commented Feb 23, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d12e74c
Status: ✅  Deploy successful!
Preview URL: https://4099fb40.immich.pages.dev
Branch Preview URL: https://feat-web-improve-search-filt.immich.pages.dev

View logs

@alextran1502
Copy link
Contributor

The see all people button looks out of place when you put it on the same line of the PEOPLE text 🤔 I'd prefer it to be in the old place

@michelheusschen
Copy link
Contributor Author

The see all people button looks out of place when you put it on the same line of the PEOPLE text 🤔 I'd prefer it to be in the old place

I put it above the people to prevent the button from jumping around after you click it, but your call

@alextran1502
Copy link
Contributor

yeah I would like to have it put back to the previous place

@michelheusschen
Copy link
Contributor Author

Moved it back and updated the screenshot

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is quite large. I would probably prefer to have sub-components (for instance a component for location input). Basically every comment in the code indicating a new section should be its own component IMO

@alextran1502 alextran1502 merged commit 878932f into main Feb 24, 2024
25 of 26 checks passed
@alextran1502 alextran1502 deleted the feat/web-improve-search-filter-design branch February 24, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants