New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): improve search filter design #7367
Conversation
Deploying with Cloudflare Pages
|
The see all people button looks out of place when you put it on the same line of the PEOPLE text 🤔 I'd prefer it to be in the old place |
I put it above the people to prevent the button from jumping around after you click it, but your call |
yeah I would like to have it put back to the previous place |
Moved it back and updated the screenshot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is quite large. I would probably prefer to have sub-components (for instance a component for location input). Basically every comment in the code indicating a new section should be its own component IMO
See all people
button when all people are already shownFilters
text for a cleaner lookBefore
After