-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): Added password field visibility toggle #7368
Conversation
Thanks for the PR and nice convenience feature, however I have a few suggestions for improvement:
As the list has gotten pretty long, I went ahead and pushed some changes. Feel free to make further adjustments as you see fit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated but might be worth adding a password input component, since at the moment those "Passwords do not match" error messages + their handling is duplicated
autocomplete={passwordAutocomplete} | ||
{required} | ||
password={value.toString()} | ||
onInput={(passwordValue) => (value = passwordValue)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really should bind value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit tricky, just doing bind:password={value}
won't work because value
in this component also handles numbers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh. I missed that, sorry...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@michelheusschen did you take note of that comment as well? What's your opinion about this? |
Validating forms in general is not done very uniformly and I think that improvements can certainly be made there. Once that's done, I'm not sure if a password confirmation component is necessary. I don't think the duplication is so bad as to be a problem, but if we decide to address it let's do it in a separate PR. |
Added a toggle button to password fields, namely:
First step for discussion: #5855
Screenshots