fix(mobile): Stop sending app to login page for unrelated auth errors #7383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
78d1c99
|
| Status: | ⚡️ Build in progress... |
martyfuhry
commented
Feb 24, 2024
| @@ -16,28 +17,31 @@ class AuthGuard extends AutoRouteGuard { | |||
| resolver.next(true); | |||
There was a problem hiding this comment.
This is the only section I'm not terribly sure about. I think we should block the resolver if Store.get(StoreKey.accessToken) excepts with a StoreKeyNotFoundException because we do that synchronously. But I didn't want to change the logic here, so I left this intact.
…nly send you to the login page when the response from the server is a 401 linter
martyfuhry
force-pushed
the
fix/mobile-auth-signout
branch
from
c04a10e
to
485baa4
Compare
|
Might fix #4850? |
Yes, I believe so. |
3 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store