refactor(web): search box #7397
Conversation
Deploying with
|
| Latest commit: |
758216c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://59b3c3ff.immich.pages.dev |
| Branch Preview URL: | https://refactor-search-box.immich.pages.dev |
danieldietzler
force-pushed
the
refactor/search-box
branch
from
8c9bea0
to
60c025e
Compare
danieldietzler
changed the title
danieldietzler
changed the title
|
Thank you for picking this up. I agree with Jason, because it allow us to only fetch the data we need instead of having to update all suggestions. If we switch to managing filters and suggestions in each component instead of in I've pushed some changed that do this for the location filters and also fix #7297. Let me know what you think and feel free to make changes or revert. |
| $: countryFilter = filter.country; | ||
| $: stateFilter = filter.state; |
There was a problem hiding this comment.
Why do we need those?
There was a problem hiding this comment.
To prevent unneeded updates when filter is reassigned, but the values of country or state haven't actually changed
There was a problem hiding this comment.
And this prevents this? From my understanding countryFilter updates whenever filter.country updates, so updateStates will update whenever filter.country changes?
There was a problem hiding this comment.
Yes, this will prevent updating like shown in this demo
There was a problem hiding this comment.
Interesting. TIL!
Thanks, I like this approach much more! |
web/src/lib/components/shared-components/search-bar/search-filter-box.svelte
Outdated
Show resolved
Hide resolved
| $: updateMakes(modelFilter); | ||
| $: updateModels(makeFilter); |
There was a problem hiding this comment.
This will have to be updated when #7382 is merged since it's calling an async function without error handling. I see the same in other files below
TheGET /search/suggestionsendpoint has been updated and returns now an object of all suggestions. As a result, theSearchSuggestionsTypehas been removed.