Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): re-render albums #7403

Merged
merged 11 commits into from Feb 28, 2024
Merged

fix(web): re-render albums #7403

merged 11 commits into from Feb 28, 2024

Conversation

martabal
Copy link
Member

What's changed

This PR fixes 2 issues:

  • Currently, when navigating from one album to another with the "Appears in" section in the detail-panel, the album infos and the timeline are not re-rendered. That's an issue we experienced with the people/[personId] route and this PR adds the same hacky solution to force re-rendering everything.
  • the toggle event for the setting-switch / slider components

Screenshots

Before After
2024-02-25.13-03-47.mp4
2024-02-25.13-03-01.mp4

Copy link

cloudflare-pages bot commented Feb 25, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: aed2146
Status: ✅  Deploy successful!
Preview URL: https://635e4ce8.immich.pages.dev
Branch Preview URL: https://fix-re-render-albums.immich.pages.dev

View logs

@waclaw66
Copy link
Contributor

Seems it could fix #4908

@alextran1502 alextran1502 merged commit 84fe41d into main Feb 28, 2024
25 checks passed
@alextran1502 alextran1502 deleted the fix/re-render-albums branch February 28, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants